Skip to content

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Dec 7, 2023

Version(s): 4.15

Issue:

  • Installing on AWS extending to Wavelength Zones (Day 0, full automated) SPLAT-1125
  • Installing on AWS with BYO VPC extending to Wavelength Zones (Day 0) SPLAT-1218
  • Extending existing cluster to Wavelength Zones (Day 2) SPLAT-1219
  • Installing on AWS extending to Wavelength Zones with nodes with public [carrier] IP (Day 0) SPLAT-1236
  • Change/Customize the cluster network MTU on AWS deployments (section with sample of install-config.yaml in Local or Wavelength [maybe something else] deployments) SPLAT-1126

Overview changes:

  • Make Local Zones pages more generic (modular) to accomodate Wavelength zones
  • Lower the "Local Zones book" to stay before Outposts (also Hybrid cloud strategy with Local and Wavelength)

Link to docs preview:

New Pages:

Updated Pages:

Local tests

PAGES=( "installing-aws-wavelength.adoc" )
PAGES+=( "installing-aws-localzone.adoc" )
for PAGE in ${PAGES[*]}; do
  asciidoctor   -a icons! -o /tmp/${PAGE}.html -v --failure-level WARN --trace   installing/installing_aws/$PAGE
  firefox /tmp/${PAGE}.html &
done

PAGES=( "aws-compute-edge-tasks.adoc" )
PAGES+=( "aws-compute-edge-tasks-wavelength.adoc" )
for PAGE in ${PAGES[*]}; do
  asciidoctor   -a icons! -o /tmp/${PAGE}.html -v --failure-level WARN --trace  post_installation_configuration//$PAGE
  firefox /tmp/${PAGE}.html &
done

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 7, 2023

@mtulio: This pull request references SPLAT-1295 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 7, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 7, 2023

🤖 Wed Dec 20 10:49:35 - Prow CI generated the docs preview: https://69128--ocpdocs-pr.netlify.app

@mtulio mtulio force-pushed the installing-aws-wavelength-zones branch 5 times, most recently from b9b65d2 to ac315da Compare December 8, 2023 02:35
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 8, 2023

@mtulio: This pull request references SPLAT-1295 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.15

Issue:

  • Installing on AWS extending to Wavelength Zones (Day 0, full automated) SPLAT-1125
  • Installing on AWS with BYO VPC extending to Wavelength Zones (Day 0) SPLAT-1218
  • Extending existing cluster to Wavelength Zones (Day 2) SPLAT-1219
  • Installing on AWS extending to Wavelength Zones with nodes with public [carrier] IP (Day 0) SPLAT-1236
  • Change/Customize the cluster network MTU on AWS deployments (section with sample of install-config.yaml in Local or Wavelength [maybe something else] deployments) SPLAT-1126

Link to docs preview:

New Pages:

Updated Pages:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 8, 2023

@mtulio: This pull request references SPLAT-1295 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.15

Issue:

  • Installing on AWS extending to Wavelength Zones (Day 0, full automated) SPLAT-1125
  • Installing on AWS with BYO VPC extending to Wavelength Zones (Day 0) SPLAT-1218
  • Extending existing cluster to Wavelength Zones (Day 2) SPLAT-1219
  • Installing on AWS extending to Wavelength Zones with nodes with public [carrier] IP (Day 0) SPLAT-1236
  • Change/Customize the cluster network MTU on AWS deployments (section with sample of install-config.yaml in Local or Wavelength [maybe something else] deployments) SPLAT-1126

Overview changes:

  • Make Local Zones pages more generic (modular) to accomodate Wavelength zones
  • Lower the "Local Zones book" to stay before Outposts (also Hybrid cloud strategy)

Link to docs preview:

New Pages:

Updated Pages:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 8, 2023

@mtulio: This pull request references SPLAT-1295 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.15

Issue:

  • Installing on AWS extending to Wavelength Zones (Day 0, full automated) SPLAT-1125
  • Installing on AWS with BYO VPC extending to Wavelength Zones (Day 0) SPLAT-1218
  • Extending existing cluster to Wavelength Zones (Day 2) SPLAT-1219
  • Installing on AWS extending to Wavelength Zones with nodes with public [carrier] IP (Day 0) SPLAT-1236
  • Change/Customize the cluster network MTU on AWS deployments (section with sample of install-config.yaml in Local or Wavelength [maybe something else] deployments) SPLAT-1126

Overview changes:

  • Make Local Zones pages more generic (modular) to accomodate Wavelength zones
  • Lower the "Local Zones book" to stay before Outposts (also Hybrid cloud strategy with Local and Wavelength)

Link to docs preview:

New Pages:

Updated Pages:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio mtulio force-pushed the installing-aws-wavelength-zones branch 11 times, most recently from e1d1940 to 0be7176 Compare December 8, 2023 20:12
@mtulio mtulio changed the title SPLAT-1295: draft/aws-installing: wavelength zones with MTU SPLAT-1295: draft/aws-installing: AWS wavelength with MTU Dec 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2023

@mtulio: This pull request references SPLAT-1295 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.15

Issue:

  • Installing on AWS extending to Wavelength Zones (Day 0, full automated) SPLAT-1125
  • Installing on AWS with BYO VPC extending to Wavelength Zones (Day 0) SPLAT-1218
  • Extending existing cluster to Wavelength Zones (Day 2) SPLAT-1219
  • Installing on AWS extending to Wavelength Zones with nodes with public [carrier] IP (Day 0) SPLAT-1236
  • Change/Customize the cluster network MTU on AWS deployments (section with sample of install-config.yaml in Local or Wavelength [maybe something else] deployments) SPLAT-1126

Overview changes:

  • Make Local Zones pages more generic (modular) to accomodate Wavelength zones
  • Lower the "Local Zones book" to stay before Outposts (also Hybrid cloud strategy with Local and Wavelength)

Link to docs preview:

New Pages:

Updated Pages:

QE review:

  • QE has approved this change.

Additional information:

Local tests

PAGES=( "installing-aws-wavelength.adoc" )
PAGES+=( "installing-aws-localzone.adoc" )
for PAGE in ${PAGES[*]}; do
 asciidoctor   -a icons! -o /tmp/${PAGE}.html -v --failure-level WARN --trace   installing/installing_aws/$PAGE
 firefox /tmp/${PAGE}.html &
done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2023

@mtulio: This pull request references SPLAT-1295 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.15

Issue:

  • Installing on AWS extending to Wavelength Zones (Day 0, full automated) SPLAT-1125
  • Installing on AWS with BYO VPC extending to Wavelength Zones (Day 0) SPLAT-1218
  • Extending existing cluster to Wavelength Zones (Day 2) SPLAT-1219
  • Installing on AWS extending to Wavelength Zones with nodes with public [carrier] IP (Day 0) SPLAT-1236
  • Change/Customize the cluster network MTU on AWS deployments (section with sample of install-config.yaml in Local or Wavelength [maybe something else] deployments) SPLAT-1126

Overview changes:

  • Make Local Zones pages more generic (modular) to accomodate Wavelength zones
  • Lower the "Local Zones book" to stay before Outposts (also Hybrid cloud strategy with Local and Wavelength)

Link to docs preview:

New Pages:

Updated Pages:

QE review:

  • QE has approved this change.

Additional information:

Local tests

PAGES=( "installing-aws-wavelength.adoc" )
PAGES+=( "installing-aws-localzone.adoc" )
for PAGE in ${PAGES[*]}; do
 asciidoctor   -a icons! -o /tmp/${PAGE}.html -v --failure-level WARN --trace   installing/installing_aws/$PAGE
 firefox /tmp/${PAGE}.html &
done

PAGES=( "aws-compute-edge-tasks.adoc" )
PAGES+=( "aws-compute-edge-tasks-wavelength.adoc" )
for PAGE in ${PAGES[*]}; do
 asciidoctor   -a icons! -o /tmp/${PAGE}.html -v --failure-level WARN --trace  post_installation_configuration//$PAGE
 firefox /tmp/${PAGE}.html &
done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2023

@mtulio: This pull request references SPLAT-1295 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.15

Issue:

  • Installing on AWS extending to Wavelength Zones (Day 0, full automated) SPLAT-1125
  • Installing on AWS with BYO VPC extending to Wavelength Zones (Day 0) SPLAT-1218
  • Extending existing cluster to Wavelength Zones (Day 2) SPLAT-1219
  • Installing on AWS extending to Wavelength Zones with nodes with public [carrier] IP (Day 0) SPLAT-1236
  • Change/Customize the cluster network MTU on AWS deployments (section with sample of install-config.yaml in Local or Wavelength [maybe something else] deployments) SPLAT-1126

Overview changes:

  • Make Local Zones pages more generic (modular) to accomodate Wavelength zones
  • Lower the "Local Zones book" to stay before Outposts (also Hybrid cloud strategy with Local and Wavelength)

Link to docs preview:

New Pages:

Updated Pages:

Local tests

PAGES=( "installing-aws-wavelength.adoc" )
PAGES+=( "installing-aws-localzone.adoc" )
for PAGE in ${PAGES[*]}; do
 asciidoctor   -a icons! -o /tmp/${PAGE}.html -v --failure-level WARN --trace   installing/installing_aws/$PAGE
 firefox /tmp/${PAGE}.html &
done

PAGES=( "aws-compute-edge-tasks.adoc" )
PAGES+=( "aws-compute-edge-tasks-wavelength.adoc" )
for PAGE in ${PAGES[*]}; do
 asciidoctor   -a icons! -o /tmp/${PAGE}.html -v --failure-level WARN --trace  post_installation_configuration//$PAGE
 firefox /tmp/${PAGE}.html &
done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio mtulio force-pushed the installing-aws-wavelength-zones branch 3 times, most recently from 55744c1 to 4c3a099 Compare December 15, 2023 01:19
Draft of user docs for Wavelength and cluster network MTU feature.
@mtulio mtulio force-pushed the installing-aws-wavelength-zones branch from 4c3a099 to 2fa9028 Compare December 15, 2023 02:00
@dfitzmau
Copy link
Contributor

/retest

@mtulio mtulio changed the title SPLAT-1295: draft/aws-installing: AWS wavelength with MTU SPLAT-1295: draft/aws-installing: AWS wavelength and custom MTU Dec 20, 2023
// Internet access for OpenShift Container Platform
include::modules/cluster-entitlements.adoc[leveloffset=+2]

// Obtaining an AWS Marketplace image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your preview for WZ, only one step is available. The same module steps for LZ should apply to WZ docs for this module?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your preview for WZ, only one step is available.

could you please elaborate that part?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP. Your PR's preview for the Obtaining an AWS Marketing Image for WZ only has one step, while the LZ doc has more steps. Should the section in oth docs be identical?

Screenshot from 2023-12-22 11-23-09

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably it was removed by mistake, the intention wasn't touch/remove that part.

endif::aws-wavelength[]

// Creating the installation files for AWS
//include::modules/installation-user-infra-generate.adoc[leveloffset=+2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is commented out, so it is no longer required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you check the rendered page, it seems to be duplicated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I cannot see the duplication. Am I missing something?

----

. The installer manifests must be created at `openshift` and `manifests` directory. Edit the
machine set manifest will be created by the {aws-service-name-single} in the directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the WZ and LZ do here after the file is configured?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfitzmau this is an optional change when the user wants to deploy a node in public subnet, instead of the default (private). The user must generate the manifests, edit the machine set manifest to set the publicIp flag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

= Verifying nodes that were created with edge compute pool

After you install a cluster that uses AWS Local Zones, check the status of the machine that was created by the machine set manifests created at install time.
After you install a cluster that uses {aws-service-name-full}, check the status of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses {aws-service-name-full} infrastructure would be clearer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it would be better

// Creating edge worker nodes in public subnets (optional)
include::modules/machineset-aws-edge-zone-public.adoc[leveloffset=+1]

//TODO: Put this back if QE validates it:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I remove these entries from PR or should I include them as commented out entries for the purpose of history tracking?

// About the cluster MTU
include::modules/nw-cluster-mtu-change-about.adoc[leveloffset=+3]

// Changing the cluster MTU
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mtulio . The preview on my PR has slightly different steps for Changing the cluster MTU section. https://69537--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/aws-compute-edge-tasks-local-zones#nw-cluster-mtu-change_aws-compute-edge-tasks-local-zones

I cannot determine why this is, but should the steps in this section match your preview?

@openshift-ci
Copy link

openshift-ci bot commented Jan 8, 2024

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented Feb 7, 2024

Closing this PR as we are working on #69537

@mtulio mtulio closed this Feb 7, 2024
@mtulio mtulio deleted the installing-aws-wavelength-zones branch February 7, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants