-
Notifications
You must be signed in to change notification settings - Fork 1.9k
SPLAT-1295: draft/aws-installing: AWS wavelength and custom MTU #69128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mtulio: This pull request references SPLAT-1295 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
|
🤖 Wed Dec 20 10:49:35 - Prow CI generated the docs preview: https://69128--ocpdocs-pr.netlify.app |
b9b65d2 to
ac315da
Compare
|
@mtulio: This pull request references SPLAT-1295 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mtulio: This pull request references SPLAT-1295 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mtulio: This pull request references SPLAT-1295 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e1d1940 to
0be7176
Compare
|
@mtulio: This pull request references SPLAT-1295 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mtulio: This pull request references SPLAT-1295 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mtulio: This pull request references SPLAT-1295 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
55744c1 to
4c3a099
Compare
Draft of user docs for Wavelength and cluster network MTU feature.
4c3a099 to
2fa9028
Compare
|
/retest |
| // Internet access for OpenShift Container Platform | ||
| include::modules/cluster-entitlements.adoc[leveloffset=+2] | ||
|
|
||
| // Obtaining an AWS Marketplace image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your preview for WZ, only one step is available. The same module steps for LZ should apply to WZ docs for this module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your preview for WZ, only one step is available.
could you please elaborate that part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NP. Your PR's preview for the Obtaining an AWS Marketing Image for WZ only has one step, while the LZ doc has more steps. Should the section in oth docs be identical?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably it was removed by mistake, the intention wasn't touch/remove that part.
| endif::aws-wavelength[] | ||
|
|
||
| // Creating the installation files for AWS | ||
| //include::modules/installation-user-infra-generate.adoc[leveloffset=+2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is commented out, so it is no longer required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you check the rendered page, it seems to be duplicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I cannot see the duplication. Am I missing something?
| ---- | ||
|
|
||
| . The installer manifests must be created at `openshift` and `manifests` directory. Edit the | ||
| machine set manifest will be created by the {aws-service-name-single} in the directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the WZ and LZ do here after the file is configured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dfitzmau this is an optional change when the user wants to deploy a node in public subnet, instead of the default (private). The user must generate the manifests, edit the machine set manifest to set the publicIp flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| = Verifying nodes that were created with edge compute pool | ||
|
|
||
| After you install a cluster that uses AWS Local Zones, check the status of the machine that was created by the machine set manifests created at install time. | ||
| After you install a cluster that uses {aws-service-name-full}, check the status of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uses {aws-service-name-full} infrastructure would be clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it would be better
| // Creating edge worker nodes in public subnets (optional) | ||
| include::modules/machineset-aws-edge-zone-public.adoc[leveloffset=+1] | ||
|
|
||
| //TODO: Put this back if QE validates it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I remove these entries from PR or should I include them as commented out entries for the purpose of history tracking?
| // About the cluster MTU | ||
| include::modules/nw-cluster-mtu-change-about.adoc[leveloffset=+3] | ||
|
|
||
| // Changing the cluster MTU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mtulio . The preview on my PR has slightly different steps for Changing the cluster MTU section. https://69537--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/aws-compute-edge-tasks-local-zones#nw-cluster-mtu-change_aws-compute-edge-tasks-local-zones
I cannot determine why this is, but should the steps in this section match your preview?
|
@mtulio: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing this PR as we are working on #69537 |

Version(s): 4.15
Issue:
Overview changes:
Link to docs preview:
New Pages:
Updated Pages:
Local tests